adixitconfluent commented on PR #20819: URL: https://github.com/apache/kafka/pull/20819#issuecomment-3495857300
> > we've used member id as Uuid and it doesn't go to the persister as well. So, I believe it should be fine > > Are you sure about it? Seems to me that we use ZERO_UUID in multiple scenarios in Share Partition and which can trigger the persister e.g. acquisition lock timeout. > > I am not suggesting to handle everything in this PR but we might want to clean this up later, not urgent. @apoorvmittal10 , we use `EMPTY_MEMBER_ID` in SharePartition, thus we are disallowing it as a member id in KafkaApis altogether. Now whatever operations need to happen with related to `EMPTY_MEMBER_ID` , example acquisition lock timeout, acknowledgements can happen independently without any effect of member id passed from the client. It is not connected to persister because member id is not passed in `WriteState` and `ReadState` RPCs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
