adixitconfluent commented on code in PR #20819:
URL: https://github.com/apache/kafka/pull/20819#discussion_r2498145572
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -4182,6 +4195,19 @@ class KafkaApis(val requestChannel: RequestChannel,
config.shareGroupConfig.isShareGroupEnabled ||
shareVersion().supportsShareGroups
}
+ /**
+ * This function checks if the member id passed from the client in KIP-932
related RPCs is valid or not. We disallow
+ * empty strings since group coordinator disallows it. We also disallow
Uuid.ZERO_UUID ("AAAAAAAAAAAAAAAAAAAAAA")
Review Comment:
I don't think there will be any problem in using an empty string`""` as an
empty member ID in SharePartition. Since we were using UUID to string
conversion in the past, I think we opted for` Uuid.ZERO_UUID
("AAAAAAAAAAAAAAAAAAAAAA")`. We can change it now. It shouldn't be a problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
