cadonna commented on a change in pull request #8613:
URL: https://github.com/apache/kafka/pull/8613#discussion_r419496703
##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter,
current_generation):
log_monitor.wait_until("Sent a version 8 subscription
and got version 7 assignment back (successful version probing). Downgrade
subscription metadata to commonly supported version 7 and trigger new
rebalance.",
timeout_sec=60,
err_msg="Could not detect
'successful version probing' at upgrading node " + str(node.account))
- else:
- log_monitor.wait_until("Sent a version 8 subscription
and got version 7 assignment back (successful version probing). Downgrade
subscription metadata to commonly supported version 8 and trigger new
rebalance.",
Review comment:
This verification is only true if the two other processors haven't
rebalanced before the processor that bounced last re-joins the group. If the
rebalance occurs, the commonly supported version is already at 8 when the last
processor joins.
Actually, the test `test_version_probing_upgrade` is independent of the used
task assignor, but this issue was surfaced by the
`HighAvailabilityTaskAssignor` but not by the `StickyTaskAssignor`. I cannot
say for sure why.
IMO, removing this verification should be OK, since afterwards we check
whether the processors have synchronized generations which means that all three
processors successfully joined the group in the end. The state that we do not
explicitly verify anymore is the transient state where version 7 is currently
used, but all processor are able to use version 8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
