cadonna commented on a change in pull request #8613:
URL: https://github.com/apache/kafka/pull/8613#discussion_r420052853
##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter,
current_generation):
log_monitor.wait_until("Sent a version 8 subscription
and got version 7 assignment back (successful version probing). Downgrade
subscription metadata to commonly supported version 7 and trigger new
rebalance.",
timeout_sec=60,
err_msg="Could not detect
'successful version probing' at upgrading node " + str(node.account))
- else:
- log_monitor.wait_until("Sent a version 8 subscription
and got version 7 assignment back (successful version probing). Downgrade
subscription metadata to commonly supported version 8 and trigger new
rebalance.",
+ log_monitor.wait_until("Detected that the assignor
requested a rebalance. Rejoining the consumer group to trigger a new
rebalance.",
Review comment:
We can leave it because it verifies whether the assignment was triggered
in the assignor. However, it does not give us any guarantee that the rebalance
took actually place.
I guess what we really would need is a way to check if a group stabilized.
We try to do that by verifying that the generations of the processors are
synced. However, I ran into cases where all processor had the same generation,
but one processor did not have any tasks assigned, because in that specific
rebalance the corresponding partitions were revoked from the other processors.
So we would actually need to check if they have the highest generation in sync
across the processors AND if all processors have at least one task assigned
(AND if all tasks were assigned).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
