ableegoldman commented on a change in pull request #8613:
URL: https://github.com/apache/kafka/pull/8613#discussion_r419829020
##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter,
current_generation):
log_monitor.wait_until("Sent a version 8 subscription
and got version 7 assignment back (successful version probing). Downgrade
subscription metadata to commonly supported version 7 and trigger new
rebalance.",
timeout_sec=60,
err_msg="Could not detect
'successful version probing' at upgrading node " + str(node.account))
- else:
- log_monitor.wait_until("Sent a version 8 subscription
and got version 7 assignment back (successful version probing). Downgrade
subscription metadata to commonly supported version 8 and trigger new
rebalance.",
+ log_monitor.wait_until("Detected that the assignor
requested a rebalance. Rejoining the consumer group to trigger a new
rebalance.",
Review comment:
I think the idea is to verify that the actual version probing rebalance
takes place, ie that the partition assignor actually handles the version
probing once it's detected. And that it signals to the stream thread which also
handles it correctly in turn. But idk -- I've probably broken and fixed the
version probing test 2 or 3 times now due to this one line in particular.
So, I'd be happy to see it go. I probably have too much bad history to make
an unbiased call here though 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
