hachikuji commented on a change in pull request #8822:
URL: https://github.com/apache/kafka/pull/8822#discussion_r436386913
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##########
@@ -852,14 +835,28 @@ public void onFailure(RuntimeException e) {
subscriptions.requestFailed(fetchPositions.keySet(),
time.milliseconds() + retryBackoffMs);
metadata.requestUpdate();
- setFatalOffsetForLeaderException(e);
+ if (!(e instanceof RetriableException)) {
Review comment:
Seemed inconsistent to have a method named `setFatal` which checks for
retriable exceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
