hachikuji commented on a change in pull request #8822:
URL: https://github.com/apache/kafka/pull/8822#discussion_r436390686
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##########
@@ -1325,23 +1323,15 @@ private CompletedFetch
initializeCompletedFetch(CompletedFetch nextCompletedFetc
return completedFetch;
}
- private void handleOffsetOutOfRange(FetchPosition fetchPosition,
- TopicPartition topicPartition,
- String reason) {
+ private void handleOffsetOutOfRange(FetchPosition fetchPosition,
TopicPartition topicPartition) {
Review comment:
After thinking about it, it seemed simpler to always use
LogTruncationException for validation failures, even if the divergent offset is
not known. Then direct OffsetOutOfRange errors are reserved for fetch responses
which indicate the OFFSET_OUT_OF_RANGE error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
