hachikuji commented on a change in pull request #8822:
URL: https://github.com/apache/kafka/pull/8822#discussion_r436387869
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##########
@@ -1050,4 +1062,43 @@ public String toString() {
'}';
}
}
+
+ public static class LogTruncation {
+ public final TopicPartition topicPartition;
+ public final FetchPosition fetchPosition;
+ public final Optional<OffsetAndMetadata> divergentOffsetOpt;
+
+ public LogTruncation(TopicPartition topicPartition,
+ FetchPosition fetchPosition,
+ Optional<OffsetAndMetadata> divergentOffsetOpt) {
+ this.topicPartition = topicPartition;
+ this.fetchPosition = fetchPosition;
Review comment:
Out of curiosity, why `fetchPosition` specifically and not the other
fields?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
