hachikuji commented on a change in pull request #8822:
URL: https://github.com/apache/kafka/pull/8822#discussion_r436387154



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##########
@@ -480,6 +480,17 @@ public synchronized boolean 
maybeValidatePositionForCurrentLeader(ApiVersions ap
                 log.debug("Skipping completed validation for partition {} 
since the current position {} " +
                                 "no longer matches the position {} when the 
request was sent",
                         tp, currentPosition, requestPosition);
+            } else if (epochEndOffset.hasUndefinedEpochOrOffset()) {

Review comment:
       If the fetch position has changed or we are no longer awaiting 
validation, we want to ignore the result. This was a bug in the previous patch 
which we didn't catch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to