wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r518837250
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -567,10 +589,34 @@ void runLoop() {
}
} catch (final TaskMigratedException e) {
handleTaskMigrated(e);
+ } catch (final Exception e) {
+ if (this.streamsUncaughtExceptionHandler.handle(e)) {
Review comment:
We could do the logic inline how ever this does make it slightly
simpler. Also we only expose the `streamsUncaughtExceptionHandler` to the user
and @vvcephei had a problem with the wrapping that again with the same type. So
we introduced a wrapper class. if we renamed it from `Handler` to
`streamsUncaughtExceptionHandlerWrapper` would that make it more clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
