wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r520104884



##########
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##########
@@ -57,6 +57,11 @@
       "name": "uniqueField",
       "versions": "8+",
       "type": "int8"
+    },
+    {
+      "name": "shutdownRequested",
+      "versions": "9+",
+      "type": "int8"

Review comment:
       https://github.com/apache/kafka/pull/9273#discussion_r486597512
   I originally had it at int32, but john suggested int16, now it is int8.
   
   would you be good with int16 or do you think int32 is the way?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to