wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r518840121
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java
##########
@@ -60,6 +60,11 @@ public void onPartitionsAssigned(final
Collection<TopicPartition> partitions) {
} else if (assignmentErrorCode.get() ==
AssignorError.ASSIGNMENT_ERROR.code()) {
log.error("Received error code {}",
AssignorError.ASSIGNMENT_ERROR);
throw new TaskAssignmentException("Hit an unexpected exception
during task assignment phase of rebalance");
+ } else if (assignmentErrorCode.get() ==
AssignorError.SHUTDOWN_REQUESTED.code()) {
+ log.error("A Kafka Streams client in this Kafka Streams
application is requesting to shutdown the application");
+ streamThread.shutdownToError();
+ taskManager.handleRebalanceComplete();
Review comment:
We can do that, it doesn't seem make difference which order it is
called. However if it is not called it will get stuck continually rebalancing.
We return because setting the state to partitions assigned will cause an error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
