wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r518850419
##########
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##########
@@ -57,6 +57,11 @@
"name": "uniqueField",
"versions": "8+",
"type": "int8"
+ },
+ {
+ "name": "shutdownRequested",
+ "versions": "9+",
+ "type": "int8"
Review comment:
I think I agree on the name, I am not sure about the type. We should be
able to fit thousands of different error code into the byte so we should not
run out of space. The reason the errorCode. is an integer in the first place is
because there is not `AtomicByte` that I know of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
