showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r787409706
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##########
@@ -511,15 +512,8 @@ private static int configureDeliveryTimeout(ProducerConfig
config, Logger log) {
private TransactionManager configureTransactionState(ProducerConfig config,
LogContext
logContext) {
-
TransactionManager transactionManager = null;
- final boolean userConfiguredIdempotence =
config.originals().containsKey(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG);
- final boolean userConfiguredTransactions =
config.originals().containsKey(ProducerConfig.TRANSACTIONAL_ID_CONFIG);
- if (userConfiguredTransactions && !userConfiguredIdempotence)
- log.info("Overriding the default {} to true since {} is
specified.", ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG,
- ProducerConfig.TRANSACTIONAL_ID_CONFIG);
-
Review comment:
We won't overriding the default `ENABLE_IDEMPOTENCE_CONFIG` because we
already default to true. No need to inform users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
