showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r787410613
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##########
@@ -540,28 +534,6 @@ private TransactionManager
configureTransactionState(ProducerConfig config,
return transactionManager;
}
- private static int configureInflightRequests(ProducerConfig config) {
- if (config.idempotenceEnabled() && 5 <
config.getInt(ProducerConfig.MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION)) {
- throw new ConfigException("Must set " +
ProducerConfig.MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + " to at most 5" +
- " to use the idempotent producer.");
- }
- return
config.getInt(ProducerConfig.MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION);
- }
-
- private static short configureAcks(ProducerConfig config, Logger log) {
- boolean userConfiguredAcks =
config.originals().containsKey(ProducerConfig.ACKS_CONFIG);
- short acks =
Short.parseShort(config.getString(ProducerConfig.ACKS_CONFIG));
-
- if (config.idempotenceEnabled()) {
- if (!userConfiguredAcks)
- log.info("Overriding the default {} to all since idempotence
is enabled.", ProducerConfig.ACKS_CONFIG);
- else if (acks != -1)
- throw new ConfigException("Must set " +
ProducerConfig.ACKS_CONFIG + " to all in order to use the idempotent " +
- "producer. Otherwise we cannot guarantee
idempotence.");
- }
- return acks;
- }
-
Review comment:
Move this idempotence configs validation into
`ProducerConfig#postProcessParsedConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
