showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r787411447
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##########
@@ -456,33 +455,29 @@ private void maybeOverrideClientId(final Map<String,
Object> configs) {
configs.put(CLIENT_ID_CONFIG, refinedClientId);
}
- private void maybeOverrideEnableIdempotence(final Map<String, Object>
configs) {
- boolean userConfiguredIdempotence =
this.originals().containsKey(ENABLE_IDEMPOTENCE_CONFIG);
- boolean userConfiguredTransactions =
this.originals().containsKey(TRANSACTIONAL_ID_CONFIG);
-
- if (userConfiguredTransactions && !userConfiguredIdempotence) {
- configs.put(ENABLE_IDEMPOTENCE_CONFIG, true);
- }
- }
-
- private void maybeOverrideAcksAndRetries(final Map<String, Object>
configs) {
+ private void postProcessAndValidateIdempotenceConfigs(final Map<String,
Object> configs) {
Review comment:
We won't override any configs now, change the method name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
