[ https://issues.apache.org/jira/browse/KAFKA-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148974#comment-13148974 ]
Jay Kreps commented on KAFKA-193: --------------------------------- This looks good to me. One thing I notice is that the type of the argument is, for example, debug(m: =>String) but the type in log4j is void debug(Object m) Is this intentional? There are two impacts from this: Good: people will no longer do error(e) The problem with this is that I think it uses e.toString which doesn't print the stack trace but just prints the message. Bad(?): I can no longer print a non-string without calling toString, e.g. debug(kafkaRequestObj) > use by name parameter helper for logging and trait to include lazy logging > and refactor code to use the new LogHelper > --------------------------------------------------------------------------------------------------------------------- > > Key: KAFKA-193 > URL: https://issues.apache.org/jira/browse/KAFKA-193 > Project: Kafka > Issue Type: Improvement > Affects Versions: 0.7 > Reporter: Joe Stein > Fix For: 0.8 > > Attachments: kafka-193.patch > > > 1) New tait to include logging and helper methods so if > (log.isDebugEnabled()) is not required because it is in the helper and log > paramaters are passed by name so not executed to tidy up the code > 2) refactor all occurrence of logging to use the log helper > 3/4 (possibly to be handled in to tickets) the "lint" affect from this for > changes patched but not on trunk and new patches moving forward until this is > baked in -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira