[
https://issues.apache.org/jira/browse/KAFKA-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149120#comment-13149120
]
Jay Kreps commented on KAFKA-193:
---------------------------------
Yeah so my recommendations.
1. Let's have the same variants for each level for consistency. Sounds like
that is info(m:=>String), info(m:=>String, t: Throwable) and info(t: Throwable).
2. I am cool with either String or Object as the message type (e.g.
info(m:=>String) or info(m:=>Object). I don't see a great benefit of the Object
type in log4j.
3. Let's definitely make the form that takes only a throwable print the stack
trace. I think t.getStackTrace() won't quite do it because the return value is
just an array. We can probably have that do info("", t), which I think would do
what we want (?) or we have a utility function which I think formats the stack
trace.
> use by name parameter helper for logging and trait to include lazy logging
> and refactor code to use the new LogHelper
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-193
> URL: https://issues.apache.org/jira/browse/KAFKA-193
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Joe Stein
> Fix For: 0.8
>
> Attachments: kafka-193.patch
>
>
> 1) New tait to include logging and helper methods so if
> (log.isDebugEnabled()) is not required because it is in the helper and log
> paramaters are passed by name so not executed to tidy up the code
> 2) refactor all occurrence of logging to use the log helper
> 3/4 (possibly to be handled in to tickets) the "lint" affect from this for
> changes patched but not on trunk and new patches moving forward until this is
> baked in
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
