[
https://issues.apache.org/jira/browse/KAFKA-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-193:
----------------------------
Attachment: kafka-193-consistent-level-throwable.fix.v2.patch
Cool, here is the same patch updated against trunk to fix a few new breakages
due to new checkins. I also made two minor changes:
1. Changed LogHelper trait to Logging and made the file name match the trait
name. Motivation here is just to make the name trait-like...
2. Made Utils.registerMbean not throw an exception. Utils.swallow was depending
on log4j and this lead to a lot of unnecessary use of log4j directly. I think
it is better for jmx registration to not be a fatal exception (JMX shouldn't
kill the server or client, just log an error).
If no objections to these I am going to apply the updated patch.
> use by name parameter helper for logging and trait to include lazy logging
> and refactor code to use the new LogHelper
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-193
> URL: https://issues.apache.org/jira/browse/KAFKA-193
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Joe Stein
> Fix For: 0.8
>
> Attachments: kafka-193-consistent-level-throwable.fix.patch,
> kafka-193-consistent-level-throwable.fix.v2.patch,
> kafka-193-consistent-level-throwable.patch, kafka-193.patch
>
>
> 1) New tait to include logging and helper methods so if
> (log.isDebugEnabled()) is not required because it is in the helper and log
> paramaters are passed by name so not executed to tidy up the code
> 2) refactor all occurrence of logging to use the log helper
> 3/4 (possibly to be handled in to tickets) the "lint" affect from this for
> changes patched but not on trunk and new patches moving forward until this is
> baked in
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
