[
https://issues.apache.org/jira/browse/KAFKA-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188862#comment-13188862
]
Jun Rao commented on KAFKA-193:
-------------------------------
We are seeing a weird issue related to this patch. The following java class
won't compile.
public class MyTest extends kafka.consumer.storage.sql.OracleOffsetStorage
{
public MyTest() {
super(null);
}
}
The compilation error is:
fatal(scala.Function0) in kafka.consumer.storage.sql.OracleOffsetStorage cannot
implement fatal(scala.Function0<java.lang.String>) in kafka.utils.Logging;
attempting to use incompatible return type
found : java.lang.Object
required: void
A similar scala class like the following compiles fine.
class MyTest() extends kafka.consumer.storage.sql.OracleOffsetStorage(null) {
}
Anyone knows the issue?
> use by name parameter helper for logging and trait to include lazy logging
> and refactor code to use the new LogHelper
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-193
> URL: https://issues.apache.org/jira/browse/KAFKA-193
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.7
> Reporter: Joe Stein
> Assignee: Jay Kreps
> Fix For: 0.8
>
> Attachments: kafka-193-consistent-level-throwable.fix.patch,
> kafka-193-consistent-level-throwable.fix.v2.patch,
> kafka-193-consistent-level-throwable.patch, kafka-193.patch
>
>
> 1) New tait to include logging and helper methods so if
> (log.isDebugEnabled()) is not required because it is in the helper and log
> paramaters are passed by name so not executed to tidy up the code
> 2) refactor all occurrence of logging to use the log helper
> 3/4 (possibly to be handled in to tickets) the "lint" affect from this for
> changes patched but not on trunk and new patches moving forward until this is
> baked in
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
