----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/#review41398 -----------------------------------------------------------
You should remove the functions from the headerfile as well. - Kai Uwe Broulik On Oct. 8, 2013, 3:13 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113175/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2013, 3:13 p.m.) > > > Review request for KDE Base Apps. > > > Repository: ark > > > Description > ------- > > This patch makes ark always use an external viewer application instead of > using the clunky internal preview thing. The internal viewer would just embed > a plain kpart into a window, but without providing any of the XMLGUI or > whatever from that part. Thus, when you for example clicked a PDF, you > couldn't print it. The advantages of the internal viewer are imo overall > quite questionable, and are far outweighted by its disadvantages. > > Plus, it removes code ;) > > > Diffs > ----- > > part/arkviewer.cpp 053cd1c0502d3bb88895dc8d3653eaea9e6c3c83 > > Diff: http://git.reviewboard.kde.org/r/113175/diff/ > > > Testing > ------- > > Clicking files opens them in the default application, as it should. > > > Thanks, > > Sven Brauch > >
