> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote: > > I'm not totally happy with this change. Yes, the internal viewer is > > limited in functionality, but it has advantages: (1) it is fast to open > > and can be closed again with a single keystroke; (2) it remembers its size > > and can be resized without affecting the default window size of, say, > > KWrite or whichever external application is used; (3) it can be forced to > > display an archive component of any type as plain text. > > > > There's nothing wrong with having the facility to open an archive component > > in its default application (or any other application), but it should be an > > option. Either a configuration setting (Use internal viewer - Use external > > application), or a context menu with options View (in the internal viewer), > > Open (in the default application) or Open With... (any other application).
I guessed some people would not be happy with it, but it was worth a try ;) How about a context menu action? Or, since the context menu is currently empty, just opening the external viewer on right-click? - Sven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/#review41400 ----------------------------------------------------------- On Oct. 8, 2013, 3:23 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113175/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2013, 3:23 p.m.) > > > Review request for KDE Base Apps. > > > Repository: ark > > > Description > ------- > > This patch makes ark always use an external viewer application instead of > using the clunky internal preview thing. The internal viewer would just embed > a plain kpart into a window, but without providing any of the XMLGUI or > whatever from that part. Thus, when you for example clicked a PDF, you > couldn't print it. The advantages of the internal viewer are imo overall > quite questionable, and are far outweighted by its disadvantages. > > Plus, it removes code ;) > > > Diffs > ----- > > part/CMakeLists.txt 9e384438b60322f1d51d31e40c556b2912970ceb > part/arkviewer.h bb41472eaec985e2e1b3d9c2f7c257c949316bf4 > part/arkviewer.cpp 053cd1c0502d3bb88895dc8d3653eaea9e6c3c83 > part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb > > Diff: http://git.reviewboard.kde.org/r/113175/diff/ > > > Testing > ------- > > Clicking files opens them in the default application, as it should. > > > Thanks, > > Sven Brauch > >
