----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113175/ -----------------------------------------------------------
(Updated Oct. 8, 2013, 3:23 p.m.) Review request for KDE Base Apps. Changes ------- No, in fact we should do this, of course. The class is worthless now. Repository: ark Description ------- This patch makes ark always use an external viewer application instead of using the clunky internal preview thing. The internal viewer would just embed a plain kpart into a window, but without providing any of the XMLGUI or whatever from that part. Thus, when you for example clicked a PDF, you couldn't print it. The advantages of the internal viewer are imo overall quite questionable, and are far outweighted by its disadvantages. Plus, it removes code ;) Diffs (updated) ----- part/CMakeLists.txt 9e384438b60322f1d51d31e40c556b2912970ceb part/arkviewer.h bb41472eaec985e2e1b3d9c2f7c257c949316bf4 part/arkviewer.cpp 053cd1c0502d3bb88895dc8d3653eaea9e6c3c83 part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb Diff: http://git.reviewboard.kde.org/r/113175/diff/ Testing ------- Clicking files opens them in the default application, as it should. Thanks, Sven Brauch
