On Wed, Jan 20, 2010 at 7:44 PM, Pavel Heimlich <tropikhajma at gmail.com>
wrote:
> I'm not sure if the improvement of several seconds would be worth it. Did you
> do any benchmarks?
No, but I can tell you unrolling qt-4.6.1 is at least a couple of
minutes. on the smaller ones,
it's probably negletable. The reason I bring it up is that
continuously unrolling a
new qt while trying to improve the build means precious minutes every
build. a ZFS
snapshot revert would make this much faster.
> From my POV the biggest annoyance is the IPS publishing which easily takes
> whole minutes.
I don't do much with IPS.
> Other points waiting for improvements might be the detection of installed
> packages (for the switch between FOSS and SUNW) in foss-depend-packages.inc,
> since pkginfo does take some time. I can imagine we could replace it with the
> check based on build number or perhaps presence of particular file in the
> system.
I would imagine that now that we have a better determining system
(base-os-selection.inc)
we can go back to the static method. However, that does mean we'd
need to either include
it in base-foss-headers.inc or one of the kde-headers. I do suspect
we may have to add some
more conditionals for open solaris revisions cause we can't force
people to build from the
latest revision. But that's a easy as
"%define osol_gt_125 %( test %{if_osolrev} -gt 125 && echo 1 | echo 0)
and then just complicating some of the conditional dependencies. But clearly
faster than exec'ing pkginfo a bunch of times.
Ben
