2010/1/21 Ben Taylor <bentaylor.solx86 at gmail.com>:
> On Wed, Jan 20, 2010 at 7:44 PM, Pavel Heimlich <tropikhajma at gmail.com>
> wrote:
>> I'm not sure if the improvement of several seconds would be worth it. Did
>> you do any benchmarks?
>
> No, but I can tell you unrolling qt-4.6.1 is at least a couple of
> minutes. ?on the smaller ones,
> it's probably negletable. ?The reason I bring it up is that
> continuously unrolling a
> new qt while trying to improve the build means precious minutes every
> build. ?a ZFS
> snapshot revert would make this much faster.
Hi Ben,
thinking about it again here's something I'd like to add:
1. this could indeed be helpful with qt (and other giants), it takes 2
minutes to unpack here - 10 builds means 20 minutes wasted.
2. but it could be very easy to break someone's fs (or break on
someone's fs), because you'll either have to make assumptions on how
the user's filesystem is structured or implement some more complex
algorithms. Certainly I wouldn't want it messing up my fs, I can mess
it up myself well enough without outside help.
I think you could use the tools/build/config file to read the user's
desired fs settings
3. be aware this is a feature people trying to just build the repo
will not really use / benefit from.
3a. using 'tar xzf pkg.tar.gz' is about 30% faster than 'gunzip
pkg.tar.gz && tar xf pkg.tar'. Changing this would benefit everyone.
4. regarding the remark about limitations, I don't think it's a real
problem, we're already limiting ourselves much more in the choice of
compiler and other things. It's reasonable to expect people running
osol and S10u8 to use ZFS.
so I think it'd be ok to implement it provided that:
1. it will not be on by default, perhaps turning it on with something
like --with-snapshots
2. the change will be reasonable and easy to maintain - not scattered
throughout 5 files, preferrably a single block of code in a single
file
my 2 c
P.
>
>> From my POV the biggest annoyance is the IPS publishing which easily takes
>> whole minutes.
>
> I don't do much with IPS.
>
>> Other points waiting for improvements might be the detection of installed
>> packages (for the switch between FOSS and SUNW) in foss-depend-packages.inc,
>> since pkginfo does take some time. I can imagine we could replace it with
>> the check based on build number or perhaps presence of particular file in
>> the system.
>
> I would imagine that now that we have a better determining system
> (base-os-selection.inc)
> we can go back to the static method. ?However, that does mean we'd
> need to either include
> it in base-foss-headers.inc or one of the kde-headers. ?I do suspect
> we may have to add some
> more conditionals for open solaris revisions cause we can't force
> people to build from the
> latest revision. ?But that's a easy as
> "%define osol_gt_125 %( test %{if_osolrev} -gt 125 && echo 1 | echo 0)
> and then just complicating some of the conditional dependencies. ?But clearly
> faster than exec'ing pkginfo a bunch of times.
>
> Ben
>
