arrowd added inline comments. INLINE COMMENTS
> dfaure wrote in ConfigureChecks.cmake:12 > I'm talking about the implementation of fileSystemSupportsACL in > kpropertiesdialog.cpp, which uses getxattr. > But now that I take another look at it, I see that it's already implemented > on FreeBSD, without the use of extattr, it uses statfs instead. > So I think I was wrong, this part is fine. > > I guess the only thing that's a bit weird is that kio_file's attr code > (unrelated to ACLs) relies on FindACL linking to the right lib (on Linux). It > would be cleaner if the attr stuff was separate. But no big deal I guess. There are other parts of code that are guarded with `HAVE_POSIX_ACL`s, and these aren't enabled ATM for FreeBSD. So, the change is needed and I'm willing to implement it. I plan to move `set(HAVE_POSIX_ACL ...)` part into `FindACL.cmake` and use this module everywhere. Does that sound OK? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh
