dfaure added inline comments. INLINE COMMENTS
> arrowd wrote in ConfigureChecks.cmake:12 > > 1. enable the ACL stuff on systems with extattr, see the little bit of code > > in kpropertiesdialog.cpp > > By that you mean that I should edit the CMake module to define > `HAVE_POSIX_ACL` when extattr headers are found? > > Or should I change checks in kpropertiesdialog.cpp from `HAVE_POSIX_ACL` to > `HAVE_*ATTR_H`? I'm talking about the implementation of fileSystemSupportsACL in kpropertiesdialog.cpp, which uses getxattr. But now that I take another look at it, I see that it's already implemented on FreeBSD, without the use of extattr, it uses statfs instead. So I think I was wrong, this part is fine. I guess the only thing that's a bit weird is that kio_file's attr code (unrelated to ACLs) relies on FindACL linking to the right lib (on Linux). It would be cleaner if the attr stuff was separate. But no big deal I guess. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh
