----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61334 -----------------------------------------------------------
CMakeLists.txt <https://git.reviewboard.kde.org/r/119043/#comment42707> Isn't it acceptable to depend on ECM here? PolkitQt-1Config.cmake.in <https://git.reviewboard.kde.org/r/119043/#comment42708> why's that change? PolkitQt-1Config.cmake.in <https://git.reviewboard.kde.org/r/119043/#comment42712> Passing the include dir is not needed anymore, given that those will be pulled by the targets. I suggest leaving them empty (or even not defining them). It won't stop applications from building, it will just resolve to nothing. PolkitQt-1Config.cmake.in <https://git.reviewboard.kde.org/r/119043/#comment42711> why don't you just do something like: set(POLKITQT-1_CORE_LIBRARY ${POLKITQT-1_CORE_PCNAME}) This should work on all platforms. core/CMakeLists.txt <https://git.reviewboard.kde.org/r/119043/#comment42709> Just use PUBLIC and PRIVATE, like the rest of frameworks core/CMakeLists.txt <https://git.reviewboard.kde.org/r/119043/#comment42713> Maybe we want to set an EXPORT_NAME? This way the user won't need a variable to link to the library. It's better linking against libraries rather than variables because you don't risk adding a typo and resolving to an empty string. - Aleix Pol Gonzalez On June 30, 2014, 9:53 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119043/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 9:53 p.m.) > > > Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and > Christophe Giboudeaux. > > > Repository: polkit-qt-1 > > > Description > ------- > > added exported targets, simplify main CMakeLists... > > > Diffs > ----- > > CMakeLists.txt 021bf88 > PolkitQt-1Config.cmake.in 8b722a6 > agent/CMakeLists.txt f1ba438 > core/CMakeLists.txt e9b3ebb > gui/CMakeLists.txt 10b06ae > polkit-qt-1.pc.cmake 2f33204 > polkit-qt-agent-1.pc.cmake 6ccc6dd > polkit-qt-core-1.pc.cmake a9e0750 > polkit-qt-gui-1.pc.cmake 6b9c2cf > polkit-qt5-1.pc.cmake PRE-CREATION > polkit-qt5-agent-1.pc.cmake PRE-CREATION > polkit-qt5-core-1.pc.cmake PRE-CREATION > polkit-qt5-gui-1.pc.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119043/diff/ > > > Testing > ------- > > builds, cmake files visually inspected, seem fine > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel