> On July 1, 2014, 1:43 a.m., Aleix Pol Gonzalez wrote: > > core/CMakeLists.txt, line 24 > > <https://git.reviewboard.kde.org/r/119043/diff/4/?file=285778#file285778line24> > > > > Maybe we want to set an EXPORT_NAME? This way the user won't need a > > variable to link to the library. > > > > It's better linking against libraries rather than variables because you > > don't risk adding a typo and resolving to an empty string.
we have export just a few lines below, so you can link to PolkitQt5-1::polkit-qt5-core-1... or i completely missed your point? other issues, to me looks could be droped? will re-add quotes to POLKITQT-1_VERSION_STRING. for the rest: as this is still both Qt4 and Qt5 library in the same branch, i would really like to avoid not needed changes. That can be done once Qt4 support is gone/moved to branch. - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61334 ----------------------------------------------------------- On June 30, 2014, 11:53 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119043/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 11:53 p.m.) > > > Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and > Christophe Giboudeaux. > > > Repository: polkit-qt-1 > > > Description > ------- > > added exported targets, simplify main CMakeLists... > > > Diffs > ----- > > CMakeLists.txt 021bf88 > PolkitQt-1Config.cmake.in 8b722a6 > agent/CMakeLists.txt f1ba438 > core/CMakeLists.txt e9b3ebb > gui/CMakeLists.txt 10b06ae > polkit-qt-1.pc.cmake 2f33204 > polkit-qt-agent-1.pc.cmake 6ccc6dd > polkit-qt-core-1.pc.cmake a9e0750 > polkit-qt-gui-1.pc.cmake 6b9c2cf > polkit-qt5-1.pc.cmake PRE-CREATION > polkit-qt5-agent-1.pc.cmake PRE-CREATION > polkit-qt5-core-1.pc.cmake PRE-CREATION > polkit-qt5-gui-1.pc.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119043/diff/ > > > Testing > ------- > > builds, cmake files visually inspected, seem fine > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
