> On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: > > agent/CMakeLists.txt, line 10 > > <https://git.reviewboard.kde.org/r/119043/diff/2/?file=285757#file285757line10> > > > > LINK_PUBLIC
> On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: > > core/CMakeLists.txt, line 13 > > <https://git.reviewboard.kde.org/r/119043/diff/2/?file=285758#file285758line13> > > > > PUBLIC was added in CMake 2.8.12, use LINK_PUBLIC So? all frameworks is depending on cmake 2.8.12, and LINK_PUBLIC is considered deprecated there. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61326 ----------------------------------------------------------- On June 30, 2014, 9:53 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119043/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 9:53 p.m.) > > > Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and > Christophe Giboudeaux. > > > Repository: polkit-qt-1 > > > Description > ------- > > added exported targets, simplify main CMakeLists... > > > Diffs > ----- > > CMakeLists.txt 021bf88 > PolkitQt-1Config.cmake.in 8b722a6 > agent/CMakeLists.txt f1ba438 > core/CMakeLists.txt e9b3ebb > gui/CMakeLists.txt 10b06ae > polkit-qt-1.pc.cmake 2f33204 > polkit-qt-agent-1.pc.cmake 6ccc6dd > polkit-qt-core-1.pc.cmake a9e0750 > polkit-qt-gui-1.pc.cmake 6b9c2cf > polkit-qt5-1.pc.cmake PRE-CREATION > polkit-qt5-agent-1.pc.cmake PRE-CREATION > polkit-qt5-core-1.pc.cmake PRE-CREATION > polkit-qt5-gui-1.pc.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119043/diff/ > > > Testing > ------- > > builds, cmake files visually inspected, seem fine > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
