> On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 6 > > <https://git.reviewboard.kde.org/r/119043/diff/4/?file=285775#file285775line6> > > > > Isn't it acceptable to depend on ECM here?
not a wise choice. the master branch allows building both the Qt4 & Qt5 variant (and depends on CMake 2.8.11) > On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > core/CMakeLists.txt, line 13 > > <https://git.reviewboard.kde.org/r/119043/diff/4/?file=285778#file285778line13> > > > > Just use PUBLIC and PRIVATE, like the rest of frameworks PUBLIC and PRIVATE do not exist in cmake 2.8.11. > On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > PolkitQt-1Config.cmake.in, line 24 > > <https://git.reviewboard.kde.org/r/119043/diff/4/?file=285776#file285776line24> > > > > Passing the include dir is not needed anymore, given that those will be > > pulled by the targets. > > > > I suggest leaving them empty (or even not defining them). It won't stop > > applications from building, it will just resolve to nothing. ...but would not be SC. Anything using POLKITQT-1_INCLUDE_DIR would fail to build. - Christophe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61334 ----------------------------------------------------------- On June 30, 2014, 9:53 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119043/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 9:53 p.m.) > > > Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and > Christophe Giboudeaux. > > > Repository: polkit-qt-1 > > > Description > ------- > > added exported targets, simplify main CMakeLists... > > > Diffs > ----- > > CMakeLists.txt 021bf88 > PolkitQt-1Config.cmake.in 8b722a6 > agent/CMakeLists.txt f1ba438 > core/CMakeLists.txt e9b3ebb > gui/CMakeLists.txt 10b06ae > polkit-qt-1.pc.cmake 2f33204 > polkit-qt-agent-1.pc.cmake 6ccc6dd > polkit-qt-core-1.pc.cmake a9e0750 > polkit-qt-gui-1.pc.cmake 6b9c2cf > polkit-qt5-1.pc.cmake PRE-CREATION > polkit-qt5-agent-1.pc.cmake PRE-CREATION > polkit-qt5-core-1.pc.cmake PRE-CREATION > polkit-qt5-gui-1.pc.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119043/diff/ > > > Testing > ------- > > builds, cmake files visually inspected, seem fine > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
