gregormi added a comment.
First of all, thanks for adding this feature. This was missing a long time :-). I will do some comments in the code. INLINE COMMENTS > kmoretools.h:488-491 > + QUrl appstreamUrl() const; > + > + void setAppstreamUrl(const QUrl& url); > + Please add a comment and add something like "@since 5.xx" (see elsewhere in the this file) to indicate since which frameworks version this will be available. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi Cc: kde-frameworks-devel, michaelh, ngraham, bruns