gregormi added inline comments.

INLINE COMMENTS

> kmoretools.h:500
> +     */
> +    void setAppstreamUrl(const QUrl& url);
> +

I am not so familiar with appstream. Why not only setting the COMPONENT-ID 
instead of the whole URL? Then the method would be named 
setAppstreamComponentId.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to