dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed.
Looks already pretty good to me, but please add API documentation. Rule of thumb: if you extend a header file that is documented, then follow this scheme and also document your new functions INLINE COMMENTS > kmoretools.h:488 > > + QUrl appstreamUrl() const; > + API documentation is missing. Please also add @since 5.48, since this will be the next frameworks release, see: https://community.kde.org/Schedules/Frameworks REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
