gregormi added inline comments.
INLINE COMMENTS
> kmoretoolspresets.cpp:59
> //
> - ADD_ENTRY("angrysearch", 0,
> "https://github.com/DoTheEvo/ANGRYsearch";);
> - ADD_ENTRY("com.uploadedlobster.peek", 0,
> "https://github.com/phw/peek";); // easy to use screen recorder, creates gif
> - ADD_ENTRY("catfish", 1,
> "http://www.twotoasts.de/index.php/catfish/";);
> - ADD_ENTRY("ding", 0,
> "https://www-user.tu-chemnitz.de/~fri/ding/";); // Offline dict, Online:
> http://dict.tu-chemnitz.de/dings.cgi
> - ADD_ENTRY("disk", 0,
> "https://en.opensuse.org/YaST_Disk_Controller";);
> - ADD_ENTRY("fontinst", 0,
> "https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/fontinst/";); // good
> for previewing many fonts at once
> - ADD_ENTRY("fontmatrix", 0,
> "https://github.com/fontmatrix/fontmatrix";);
> - ADD_ENTRY("fsearch", 0,
> "http://www.fsearch.org/";);
> - ADD_ENTRY("giggle", 1,
> "https://wiki.gnome.org/Apps/giggle/";); // good for searching in history
> - ADD_ENTRY("git-cola-folder-handler", 1,
> "https://git-cola.github.io";);
> - ADD_ENTRY("git-cola-view-history.kmt-edition", 1,
> "https://git-cola.github.io";);
> - ADD_ENTRY("gitk.kmt-edition", 1,
> "http://git-scm.com/docs/gitk";);
> - ADD_ENTRY("qgit.kmt-edition", 1,
> "http://libre.tibirna.org/projects/qgit";);
> - ADD_ENTRY("gitg", 1,
> "https://wiki.gnome.org/action/show/Apps/Gitg?action=show&redirect=Gitg";);
> - ADD_ENTRY("gnome-search-tool", 0,
> "https://help.gnome.org/users/gnome-search-tool/";); // has good filtering
> options
> - ADD_ENTRY("gucharmap", 0,
> "https://wiki.gnome.org/action/show/Apps/Gucharmap";);
> - ADD_ENTRY("gparted", 0, "http://gparted.org";);
> - ADD_ENTRY("htop", 0,
> "http://hisham.hm/htop/";);
> - ADD_ENTRY("hotshots", 1,
> "http://sourceforge.net/projects/hotshots/";);
> - ADD_ENTRY("kaption", 0,
> "http://kde-apps.org/content/show.php/?content=139302";);
> - ADD_ENTRY("kding", 0, ""); // Offline dict;
> unmaintained?
> - ADD_ENTRY("org.kde.kmousetool", 0,
> "https://www.kde.org/applications/utilities/kmousetool/";);
> - ADD_ENTRY("org.gnome.clocks", 0,
> "https://wiki.gnome.org/Apps/Clocks";);
> - ADD_ENTRY("org.kde.filelight", 1,
> "https://utils.kde.org/projects/filelight";);
> - ADD_ENTRY("org.kde.kcharselect", 0,
> "https://utils.kde.org/projects/kcharselect/";);
> - ADD_ENTRY("org.kde.kdf", 0,
> "https://www.kde.org/applications/system/kdiskfree";);
> - ADD_ENTRY("org.kde.kfind", 1,
> "https://www.kde.org/applications/utilities/kfind/";); // has good filtering
> options
> - ADD_ENTRY("org.kde.partitionmanager", 0,
> "https://www.kde.org/applications/system/kdepartitionmanager/";);
> - ADD_ENTRY("org.kde.plasma.cuttlefish.kmt-edition", 0,
> "http://vizzzion.org/blog/2015/02/say-hi-to-cuttlefish/";);
> - ADD_ENTRY("org.kde.ksysguard", 0,
> "https://userbase.kde.org/KSysGuard";);
> - ADD_ENTRY("org.kde.ksystemlog", 0,
> "https://www.kde.org/applications/system/ksystemlog/";);
> - ADD_ENTRY("org.kde.ktimer", 0,
> "https://www.kde.org/applications/utilities/ktimer/";);
> - ADD_ENTRY("org.kde.spectacle", 0,
> "https://www.kde.org/applications/graphics/spectacle";);
> - ADD_ENTRY("simplescreenrecorder", 0,
> "http://www.maartenbaert.be/simplescreenrecorder/";);
> - ADD_ENTRY("shutter", 0,
> "http://shutter-project.org";); // good for edit screenshot after capture
> - ADD_ENTRY("vokoscreen", 0,
> "https://github.com/vkohaupt/vokoscreen";); // feature-rich screen recorder
> - ADD_ENTRY("xfce4-taskmanager", 0,
> "http://goodies.xfce.org/projects/applications/xfce4-taskmanager";);
> + ADD_ENTRY("angrysearch", 0,
> "https://github.com/DoTheEvo/ANGRYsearch";, "");
> + ADD_ENTRY("com.uploadedlobster.peek", 0,
> "https://github.com/phw/peek";, ""); // easy to use screen recorder, creates
> gif
I have these thoughts when I see the ADD_ENTRY lines:
1. Appstream data is _the_ important source of app data. So I would move it
directly after the URL count and before the homepage
2. Mostly, desktopEntryName and appstreamComponentId are equal. So, maybe one
could use a placeholder (e.g. ~) to reuse the desktopEntryName
ADD_ENTRY("catfish", 1, "http://www.twotoasts.de/index.php/catfish/";,
"appstream://catfish");
would become
ADD_ENTRY("catfish", 1, "~", "http://www.twotoasts.de/index.php/catfish/";);
ADD_ENTRY("giggle", 1, "https://wiki.gnome.org/Apps/giggle/";,
"appstream://giggle.desktop");
would become
ADD_ENTRY("giggle", 1, "giggle.desktop", "https://wiki.gnome.org/Apps/giggle/";);
But in the end this is only cosmetics and not required to land this patch.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D13706
To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
