-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Tom Rini wrote: > On Thu, May 03, 2007 at 10:45:55AM -0500, Jason Wessel wrote: > >> Greetings KGDB experts, >> >> I upreved the patches from the 2.6.18 testing git archive and patched in >> the missing files from the 2.6.18 git master archive on kernel.org. >> Kgdboe compiles and works with a trivial breakpoint test on at least one >> board in ia32, x86_64, ppc32, ppc64, mips32, mips64, ARM, XScale. The >> current patch set is for the 2.6.21.1kernel.org kernel. > > Good job! > > [snip] >> ----- Patch for consideration #1 ----- >> Moved weak definitions to kernel/kgdbarchlib.c to get rid of gcc-4.1 bug. >> >> http://kgdb.cvs.sourceforge.net/kgdb/kgdb-2/core-lite.patch?r1=1.125&r2=1.126&pathrev=MAIN > > If this is fixed in a current gcc-4.1 release, I'd be really against > this. Perhaps a compiler check in <linux/kgdb.h> with some good > comments (gcc bug url and such) instead?
I don't understand why you are against it. Most of it is simply moving the weak declarations from kgdb.c to kgdbarchlib.c to avoid the gcc-4.1 bug with weak declarations. What's the harm in making the code resistant to gcc bugs. My guess is that you think it will be more difficult to maintain or something. Placing the weak function in a separate gdbarchlib.c seems ok to me. If it's not going in, I like the idea of a compiler check. - -piet > >> - Bob Pico posted some IA64 patches, I am happy to up merge, but I do >> not have an IA64 system > > FWIW, I had been just accepting Bob's changes as I didn't have any ia64 > access either. > >> - sh-sci.c needs an actual port from the 2.6.18 branch. I have the >> original patch if >> someone is interested. Some of the internals of this have changed so >> someone more >> familiar with this code should merge it (hopefully this person has a >> board to test it). > > It might be worthing poking the LinuxSH list to see if anyone wants to > step up and keep an eye on KGDB/SH. I primarily did this port because I > had the hardware and to try and prove it really was easy enough to add > another arch, given an existing stub somewhere. I no longer have the > hardware I did this port on. > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGOnbtJICwm/rv3hoRAv30AJ4iBwjoxid9ujcrIjWC1a5u710NMgCbBlij sa4MpxNJtghkJH7zPE03xWg= =RmB5 -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Kgdb-bugreport mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
