Peter Memishian wrote:
> > I don't understand what the "problem" is with the way Roland has
> > implemented this? Is it a _big_ problem - or is is simply your
> > personal preference?
>
> Roger (cc'd on this email) is the right person to engage for the
> philosophical argument for it -- I am merely asking for consistency
> with the way the rest of our Makefiles work. The changes necessary
> to provide that consistency are minor and should take less than an
> hour (at most) to implement.
>
> Again, it is not about personal preference. It's about consistency and
> simplicity.
>
>
+1. And, I hope we are not going to sacrifice quality considerations in
OpenSolaris just because the work is being done by unpaid volunteers.
I've worked on Solaris both in paid and unpaid capacities, and I really,
really don't want to degenerate into the "oh well, its good enough"
approach.
In fact, as a result of this, I have spent significant time (off the
clock) cleaning up some of the ethernet drivers so that they are vastly
cleaner ... the ones I've touched pass lint (with no special LINTTAGS
anymore), pass cstyle, and have a lot of duplication and dead #ifdef
code removed. Nobody who uses the drivers will ever notice, but from
absolute code quality improvement standpoint, the improvement is
significant, IMO.
-- Garrett
