On Thursday 06 March 2008 17:14:34 Ingo Molnar wrote: > * Yang, Sheng <[EMAIL PROTECTED]> wrote: > > + /* Though spec said the state of 8254 is undefined after power-up, > > + * seems some tricky OS like Windows XP depends on IRQ0 interrupt > > + * when booting up. > > + * So here setting initialize rate for it, and not a specific number */ > > another silly style nit, the canonical comment style is: > > + /* > > + * Though spec said the state of 8254 is undefined after power-up, > > + * seems some tricky OS like Windows XP depends on IRQ0 interrupt > > + * when booting up. > > + * So here setting initialize rate for it, and not a specific number > > + */ > > we are standardizing on that in other areas of arch/x86 and KVM uses > that too.
... Seems I still can't fully depend on script/checkpatch.pl to correct my coding style error... > but your patch looks good otherwise :) > > /me goes back into lurker mode > > Ingo Thanks for review! :) Yang, Sheng ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel