To be honest I don't remember the motivation for supporting parsing values from comments in CSS. The use of regular @settings nodes seems more Leonine to me. But that also seems to require iterative substitution. When the system was working, it supported both. Although I disagree with your desire to have static stylesheets(*), I don't think it would take any changes to the existing code to do that. Just store the output from expand_css_constants() in @data qt-plugin-style-sheet, or whatever it's called. (*) because static stylesheets force anyone who wants to tweak a color or font size in a theme to recompile the whole stylesheet, vs. just changing a single @setting. My offer to take a look at this remains, but I can't do anything while you're changing things around. Also, based on the git log message experience, I think it would be really useful to have all these changes isolated in a branch, so if any rolling back is needed, there are interspersed unrelated commits to avoid. Cheers -Terry From: Edward K. Ream <edream...@gmail.com> To: leo-editor <leo-editor@googlegroups.com> Sent: Tuesday, March 7, 2017 2:20 PM Subject: Re: Proposal: simplify style sheets for Leo 5.6, or maybe 5.5b1 On Tuesday, March 7, 2017 at 2:02:37 PM UTC-6, Edward K. Ream wrote:
An easy rule eliminates iterative replacement: the substitution must either be a constant or an already-defined name. So the following lines are legal: solarized-base03 = #002b36 tree-bg = colarized-base03 text-font = Verdana body-font = text-font I suppose this could be confusing. These lines can define arbitrarily many levels of indirection, but the code that implements that indirection is no longer iterative. The code that scans the lines above maintains a dict of name/value pairs. A non-constant must already be in the dict. No more loops. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.