Jim Gifford wrote:
Based on comments that I have received, I've updated the script. I will start putting in a version # at the top. Thank you all for you comments and suggestions. I really appreciate them.


Cool, Jim. Overall, good work. A couple of things:

* As the script currently is, it requires that you always use '/usr/src' and that the user running the script have write access to that dir. I think it might be useful to have the script run in the current working directory - or at the very least, be able to specify in which dir to run.

* Your script uses the flag --passive-ftp to wget. On my version of wget, 1.9.1, the proper flag is --passive. Is --passive-ftp correct on older versions or is this just a typo?

I've included a patch that resolves both of the above issues.

Also, if we get this working, might it be useful to add in the multilib header stubs all at once instead of having to maintain patches for the book? Or, at least make it so the script can also generate the new patches.

Just a couple of thoughts. Hope they're helpful.

--
JH
--- headers.orig        2006-03-08 10:44:24.458342956 -0500
+++ headers     2006-03-08 11:08:01.893688736 -0500
@@ -9,15 +9,14 @@
        exit 255
 else
        echo "Downloading kernel linux-$VERSION from kernel.org..."
-       cd /usr/src
        if ! [ -e linux-$VERSION.tar.bz2 ]; then
-               wget --quiet --passive-ftp 
http://www.kernel.org/pub/linux/kernel/v2.6/linux-$VERSION.tar.bz2
+               wget --quiet --passive 
http://www.kernel.org/pub/linux/kernel/v2.6/linux-$VERSION.tar.bz2
                if [ "$?" != "0" ]; then
                        echo "Error during Download."
                        exit 255
                fi
        fi
-       echo "Decompressing Kernel Headers only in /usr/src..."
+       echo "Decompressing Kernel Headers only..."
        rm -rf linux-$VERSION linux-headers-$VERSION linux-headers-$VERSION.orig
        tar jxf linux-$VERSION.tar.bz2 linux-$VERSION/include/* 
        echo "Renaming directory to linux-headers-$VERSION..."
-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to