On 2012-08-09 03:31:30 +0200, Diego Biurrun wrote:
> Yes, this is a crude attempt at trolling Justin into keeping the only
> lib without Doxygen warnings that way.
> ---
> 
> SCNR ;-p
> 
>  libavresample/resample.c |    9 ++-------
>  1 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/libavresample/resample.c b/libavresample/resample.c
> index 1c3d13a..161388b 100644
> --- a/libavresample/resample.c
> +++ b/libavresample/resample.c
> @@ -69,6 +69,7 @@ struct ResampleContext {
>  
>  /**
>   * 0th order modified bessel function of the first kind.
> + * @param x FIXME: i want to be documented
>   */

drop it, documenting arguments to mathematical functions is silly

>  static double bessel(double x)
>  {
> @@ -89,13 +90,7 @@ static double bessel(double x)
>  /**
>   * Build a polyphase filterbank.
>   *
> - * @param[out] filter       filter coefficients
> - * @param      factor       resampling factor
> - * @param      tap_count    tap count
> - * @param      phase_count  phase count
> - * @param      scale        wanted sum of coefficients for each filter
> - * @param      filter_type  filter type
> - * @param      kaiser_beta  kaiser window beta
> + * @param c FIXME: i want to be documented
>   * @return                  0 on success, negative AVERROR code on failure

drop it or document it as 'an ResampleContext'

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to