I think that all sounds good, but that kind of rework is probably going to involve a lot of regression risk (what are the tests like right now?), but also a ton of opportunities for improvements to the extent that it might be a good time to make a break from backward functional compatibility, maybe brand it as something else, and market it as the next gen or something like that. It sounds like the code as it is is in kind of a bad state, we've got people here on this list that care about that code but don't have time to do much more than review your changes, but then you are showing a lot of initiative to contribute and have the skills and interest to take this kind of project on. We could all just take a step back and see what you do?
On Mon, May 6, 2024 at 10:06 AM Steph Phillips <stephbotco...@gmail.com> wrote: > > Well, I'm glad you asked about feedback because I'm curious what other > folks who contribute to Frescobaldi might think. > > After digging around in the codebase, I'm wondering if the application > might benefit from a more object-oriented design. It's definitely in > Python, but with more of C-style approach. You've worked on it, you know > what I'm talking about. Was wondering what your thoughts are. > > Additionally, I was wondering if it might benefit from typehinting > throughout the codebase to allow for easier maintenance and plugin > development. > > Thoughts? ♥ > > ------ Original Message ------ > From "Jean Abou Samra" <j...@abou-samra.fr> > To "Steph Phillips" <stephbotco...@gmail.com>; "Graham King" > <lilyp...@tremagi.org.uk>; "N. Andrew Walsh" <n.andrew.wa...@gmail.com> > Cc "Lilypond-User Mailing List" <lilypond-user@gnu.org> > Date 5/6/2024 7:00:17 AM > Subject Re: Re[2]: Frescobaldi? > > > > >> Hey all, I've been looking over the Frescobaldi codebase for the last > >> few days, and it seems to be within the realm of something I could pick > >> up maintenance for. > >> > >> There would definitely be a learning curve, so hopefully it doesn't > >> reach it's EOL too soon... But, I don't know, I feel pretty confident. > >> > >> Not really sure what more info I can contribute to the public discourse > >> at this point, but I welcome anyone else interested with the upkeep of > >> Frescobaldi to get in touch with me so we can coordinate~ > > > > > > > >I'd encourage you to start by fixing some small issues to get acquainted > >with the code. Then if you want to do the Qt 6 port, work on a branch > >and make it public so I (for example) can have a look (don't wait for > >having finished the port before seeking feedback). > > > >Thanks, > >Jean > > > > >
