On Wed, Feb 9, 2011 at 12:15 PM, Dejan Muhamedagic <deja...@fastmail.fm> wrote: > On Wed, Feb 09, 2011 at 12:06:04PM +0100, Florian Haas wrote: >> On 2011-02-09 11:56, Dejan Muhamedagic wrote: >> >> It is plugin compatible to the old version of the agent. >> > >> > Great! Unfortunately, we can't replace the old db2 now, the >> > number of changes is very large: >> > >> > db2 | 1076 >> > +++++++++++++++++++++++++++++++++++++++++++------------------------- >> > 1 file changed, 687 insertions(+), 389 deletions(-) >> > >> > And the code is completely new (though I have no doubt that it is >> > of excellent quality). So, I'd suggest to add this as another db2 >> > RA. Once it gets some field testing we can mark the old one as >> > deprecated. What name would you suggest? db2db2? >> >> Just making sure: Is that a joke? > > A bit of a joke, yes. But the alternatives such as db22 or db2new > looked a bit boring.
I think boring is the least of our problems with those names. Are you going to change the name of every agent that gets a rewrite? IPaddr2-ng-ng-again-and-one-more-plus-one Solicit feedback, like was done for kliend's new agent, and replace the existing one it if/when people respond positively. Its not like the old one disappears from the face of the earth after you merge the new one. wget -o /usr/lib/ocf/resource.d/heartbeat/db2 http://hg.linux-ha.org/agents/file/agents-1.0.3/heartbeat/db2 > >> > HADR is a very different beast from non-HADR db, right? Why not >> > then add the "hadr" boolean parameter and use that instead of >> > checking if the resource has been configured as multi-state? >> >> I'll take responsibility for suggesting the use of ocf_is_ms(), and I'd >> be curious to find out what you think is wrong with that approach. > > There's nothing wrong in the sense whether it is going to work. > But someday, db2 may sport say HADR2 or VHA or whatever else > which may run as a ms resource. I just think that it's better to > make it obvious in the configuration that the user runs HADR. > Does that make sense? > >> Because if anything is, then the mysql RA needs fixing too. > > No idea what's up with mysql. > > Cheers, > > Dejan > >> Florian >> > > > >> _______________________________________________________ >> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev >> Home Page: http://linux-ha.org/ > > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ > _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
