* Thomas Gleixner <t...@linutronix.de> wrote:
> On Thu, 8 Sep 2016, Ingo Molnar wrote:
> > * Masahiro Yamada <yamada.masah...@socionext.com> wrote:
> > > static unsigned long set_apic_id(unsigned int id)
> > > {
> > > - unsigned long x;
> > > -
> > > /* maskout x2apic_extra_bits ? */
> > > - x = id;
> > > - return x;
> > > + return id;
> > > }
> >
> > This was clearly left there to document a quirk and as a placeholder for
> > future
> > changes.
>
> Keeping the comment and rewording it to:
>
> /* CHECKME: Do we need to mask out the xapic extra bits */
>
> should be good enough. The variable dance is not really giving any value.
Yeah, sure - my point was that the mindless removal is wrong.
Thanks,
Ingo
