On 7/21/19 8:58 AM, Bharath Vedartham wrote: > is_vm_hugetlb_page has checks for whether CONFIG_HUGETLB_PAGE is defined > or not. If CONFIG_HUGETLB_PAGE is not defined is_vm_hugetlb_page will > always return false. There is no need to have an uneccessary > CONFIG_HUGETLB_PAGE check in the code. > > Cc: Ira Weiny <ira.we...@intel.com> > Cc: John Hubbard <jhubb...@nvidia.com> > Cc: Jérôme Glisse <jgli...@redhat.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Dimitri Sivanich <sivan...@sgi.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: linux-kernel@vger.kernel.org > Cc: linux...@kvack.org > Signed-off-by: Bharath Vedartham <linux.b...@gmail.com> > --- > drivers/misc/sgi-gru/grufault.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c > index 61b3447..75108d2 100644 > --- a/drivers/misc/sgi-gru/grufault.c > +++ b/drivers/misc/sgi-gru/grufault.c > @@ -180,11 +180,8 @@ static int non_atomic_pte_lookup(struct vm_area_struct > *vma, > { > struct page *page; > > -#ifdef CONFIG_HUGETLB_PAGE > *pageshift = is_vm_hugetlb_page(vma) ? HPAGE_SHIFT : PAGE_SHIFT; > -#else > - *pageshift = PAGE_SHIFT; > -#endif > + > if (get_user_pages(vaddr, 1, write ? FOLL_WRITE : 0, &page, NULL) <= 0) > return -EFAULT; > *paddr = page_to_phys(page); > @@ -238,11 +235,9 @@ static int atomic_pte_lookup(struct vm_area_struct *vma, > unsigned long vaddr, > return 1; > > *paddr = pte_pfn(pte) << PAGE_SHIFT; > -#ifdef CONFIG_HUGETLB_PAGE > + > *pageshift = is_vm_hugetlb_page(vma) ? HPAGE_SHIFT : PAGE_SHIFT; > -#else > - *pageshift = PAGE_SHIFT; > -#endif > + > return 0; > > err: >
Looks like an accurate cleanup to me. Reviewed-by: John Hubbard <jhubb...@nvidia.com> thanks, -- John Hubbard NVIDIA