[PATCH v2 03/22] watchdog: ziirave_wdt: Be more verbose during firmware update

[Andrey Smirnov]

Add more error logging to ziirave_firm_upload() for diagnostics.

Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com>
Reviewed-by: Guenter Roeck <li...@roeck-us.net>
Cc: Chris Healy <cphe...@gmail.com>
Cc: Guenter Roeck <li...@roeck-us.net>
Cc: Rick Ramstetter <r...@anteaterllc.com>
Cc: linux-watch...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/watchdog/ziirave_wdt.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
index 8c71341a9c1c..b3e255b40209 100644
--- a/drivers/watchdog/ziirave_wdt.c
+++ b/drivers/watchdog/ziirave_wdt.c
@@ -335,14 +335,18 @@ static int ziirave_firm_upload(struct watchdog_device 
*wdd,
 
        ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_JUMP_TO_BOOTLOADER, 1,
                                      false);
-       if (ret)
+       if (ret) {
+               dev_err(&client->dev, "Failed to jump to bootloader\n");
                return ret;
+       }
 
        msleep(500);
 
        ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_DOWNLOAD_START, 1, true);
-       if (ret)
+       if (ret) {
+               dev_err(&client->dev, "Failed to start download\n");
                return ret;
+       }
 
        msleep(500);
 
@@ -438,14 +442,20 @@ static int ziirave_firm_upload(struct watchdog_device 
*wdd,
 
        /* End download operation */
        ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_DOWNLOAD_END, 1, false);
-       if (ret)
+       if (ret) {
+               dev_err(&client->dev,
+                       "Failed to end firmware download: %d\n", ret);
                return ret;
+       }
 
        /* Reset the processor */
        ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_RESET_PROCESSOR, 1,
                                      false);
-       if (ret)
+       if (ret) {
+               dev_err(&client->dev,
+                       "Failed to reset the watchdog: %d\n", ret);
                return ret;
+       }
 
        msleep(500);
 
-- 
2.21.0