Well, this is almost cosmetics, and I am not maintaner, but... On 02/16, Mandeep Singh Baines wrote: > > static inline bool try_to_freeze(void) > { > + if (current->flags & PF_NOFREEZE) > + return false; > + debug_check_no_locks_held(current, "lock held while trying to freeze");
I think this should be if (!(current->flags & PF_NOFREEZE)) debug_check_no_locks_held(...); without "return". This way we avoid the unnecessary PF_NOFREEZE check if !CONFIG_LOCKDEP. And perhaps more importantly, this way it is clear that we check PF_NOFREEZE for debugging only and do not change the code behaviour. But I leave this to Rafael/Tejun. And again, unless I missed something, this makes 1/5 unnecessary. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/