In

  $ perf diff -c wdiff:M,N

color the numbers in the Weighted Diff column either green or red,
depending on whether the number is positive or negative.

Cc: Jiri Olsa <jo...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artag...@gmail.com>
---
 tools/perf/builtin-diff.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index be2550c..f3f5d8e 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -777,6 +777,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
                container_of(fmt, struct diff_hpp_fmt, fmt);
        struct hist_entry *pair = get_pair_fmt(he, dfmt);
        double delta;
+       s64 wdiff;
        char pfmt[20] = " ";
 
        if (!pair)
@@ -789,6 +790,9 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
                case COMPUTE_RATIO:
                        delta = pair->diff.period_ratio;
                        break;
+               case COMPUTE_WEIGHTED_DIFF:
+                       wdiff = pair->diff.wdiff;
+                       break;
                default:
                        BUG_ON(1);
                }
@@ -800,6 +804,9 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
                case COMPUTE_RATIO:
                        delta = compute_ratio(he, pair);
                        break;
+               case COMPUTE_WEIGHTED_DIFF:
+                       wdiff = compute_wdiff(he, pair);
+                       break;
                default:
                        BUG_ON(1);
                }
@@ -819,6 +826,12 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
                        return percent_color_snprintf(hpp->buf, hpp->size,
                                                pfmt, delta);
                        break;
+               case COMPUTE_WEIGHTED_DIFF:
+                       scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
+                       return color_snprintf(hpp->buf, hpp->size,
+                                       wdiff > 0 ? PERF_COLOR_GREEN : 
PERF_COLOR_RED,
+                                       pfmt, wdiff);
+                       break;
                default:
                        BUG_ON(1);
                }
@@ -840,6 +853,12 @@ static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
        return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
 }
 
+static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
+                       struct perf_hpp *hpp, struct hist_entry *he)
+{
+       return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
+}
+
 static void
 hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
 {
@@ -1024,6 +1043,9 @@ static void data__hpp_register(struct data__file *d, int 
idx)
        case PERF_HPP_DIFF__RATIO:
                fmt->color = hpp__color_ratio;
                break;
+       case PERF_HPP_DIFF__WEIGHTED_DIFF:
+               fmt->color = hpp__color_wdiff;
+               break;
        default:
                break;
        }
-- 
1.8.5.rc0.5.g70ebc73.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to