On Sun, Nov 24, 2013 at 11:50:22AM +0530, Ramkumar Ramachandra wrote: > Color the numbers in the Delta column either green or red depending on > whether the number is positive or negative. > > Cc: Jiri Olsa <jo...@redhat.com> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > Signed-off-by: Ramkumar Ramachandra <artag...@gmail.com> > --- > tools/perf/builtin-diff.c | 37 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c > index 79e0448..84d5f2d 100644 > --- a/tools/perf/builtin-diff.c > +++ b/tools/perf/builtin-diff.c > @@ -769,6 +769,33 @@ static int hpp__entry_baseline(struct hist_entry *he, > char *buf, size_t size) > return ret; > } > > +static int hpp__color_delta(struct perf_hpp_fmt *fmt, > + struct perf_hpp *hpp, struct hist_entry *he) > +{ > + struct diff_hpp_fmt *dfmt = > + container_of(fmt, struct diff_hpp_fmt, fmt); > + struct hist_entry *pair = get_pair_fmt(he, dfmt); > + double percent; > + char pfmt[20] = " "; > + > + if (!pair) > + goto dummy_print;
same comment here ^^^ as for previous patch jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/