On Monday 07 February 2005 1:46 pm, Alan Stern wrote: > > When I built ohci-omap.c with your include file, another error cropped up. > The code needs to #include <asm/arch/clocks.h> for the definitions of > EN_LBFREECK and EN_LBCK. Do you want to add that in separately along with > ohci-omap.h or shall I include it in this patch?
The clock stuff is partially reworked; I'll clean all that up together (including removing the need for ohci-omap.h). Just get the usbcore parts to compile for now (with your changes) and leave the headers alone. Specifically there are changes to use <asm-arm/hardware/clock.h> clk_get() and friends, already sitting in the OMAP tree, but they need a bit of work yet. Basically the idea is to explicitly represent the clock tree -- this one is derived from that one, here's how you request it, etc -- so that drivers can ensure that the only clocks that are enabled are ones that are actually needed. (And that when you disable a clock, all no-longer-needed ancestor clocks get disabled too, saving power.) > Something else has come up. In that dev_info() message in usb_add_hcd(), > where it prints out the iomem or iobase value... For the memory-mapped > I/O case, does it make more sense to print the original I/O address or the > value of the mapped memory pointer? The former seems more meaningful to > me, but almost all the drivers do the latter. Wasn't there some > discussion about this earlier? I can't recall the outcome... Print out the hardware address; match /proc/iomem. There was a patch submitted to make that happen, maybe it got lost somewhere. - Dave > > Alan Stern > > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
